disable payload signing for uploads by default (#83)

awslabs · Jan 10, 2025 · d73d1ee · d73d1ee
1 parent 0899be0
commit d73d1ee
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 16 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,9 +15,9 @@ env:
   # Change to specific Rust release to pin
   rust_stable: stable
   rust_nightly: nightly-2024-07-07
-  rust_clippy: '1.79'
+  rust_clippy: '1.81'
   # When updating this, also update relevant docs
-  rust_min: '1.79'
+  rust_min: '1.81'
 
 
 defaults:

diff --git a/aws-s3-transfer-manager/Cargo.toml b/aws-s3-transfer-manager/Cargo.toml
@@ -10,14 +10,14 @@ publish = false
 
 [dependencies]
 async-channel = "2.3.1"
-async-trait = "0.1.82"
-# aws-config = { version = "1.5.6", features = ["behavior-version-latest"] }
-# aws-sdk-s3 = { version = "1.51.0", features = ["behavior-version-latest"] }
-# aws-smithy-async = "1.2.1"
+async-trait = "0.1.83"
+# aws-config = { version = "1.5.11", features = ["behavior-version-latest"] }
+# aws-sdk-s3 = { version = "1.66.0", features = ["behavior-version-latest"] }
+# aws-smithy-async = "1.2.2"
 # aws-smithy-experimental = { version = "0.1.3", features = ["crypto-aws-lc"] }
 # aws-smithy-runtime-api = "1.7.3"
-# aws-runtime = "1.4.4"
-# aws-smithy-types = "1.2.6"
+# aws-runtime = "1.5.1"
+# aws-smithy-types = "1.2.10"
 # aws-types = "1.3.3"
 aws-config = { path = "../../motorcade/aws-sdk/sdk/aws-config" }
 aws-sdk-s3 = { path = "../../motorcade/aws-sdk/sdk/s3" }
@@ -27,21 +27,21 @@ aws-smithy-runtime-api = { path = "../../motorcade/aws-sdk/sdk/aws-smithy-runtim
 aws-runtime = { path = "../../motorcade/aws-sdk/sdk/aws-runtime" }
 aws-smithy-types = { path = "../../motorcade/aws-sdk/sdk/aws-smithy-types" }
 aws-types = { path = "../../motorcade/aws-sdk/sdk/aws-types" }
-blocking = "1.6.0"
+blocking = "1.6.1"
 bytes = "1"
 bytes-utils = "0.1.4"
-futures-util = "0.3.30"
+futures-util = "0.3.31"
 path-clean = "1.0.1"
-pin-project-lite = "0.2.14"
-tokio = { version = "1.40.0", features = ["rt-multi-thread", "io-util", "sync", "fs", "macros"] }
-tower = { version = "0.5.1", features = ["limit", "retry", "util", "hedge", "buffer"] }
+pin-project-lite = "0.2.15"
+tokio = { version = "1.42.0", features = ["rt-multi-thread", "io-util", "sync", "fs", "macros"] }
+tower = { version = "0.5.2", features = ["limit", "retry", "util", "hedge", "buffer"] }
 tracing = "0.1"
 walkdir = "2"
 
 [dev-dependencies]
-# aws-sdk-s3 = { version = "1.51.0", features = ["behavior-version-latest", "test-util"] }
+# aws-sdk-s3 = { version = "1.66.0", features = ["behavior-version-latest", "test-util"] }
 # aws-smithy-mocks-experimental = "0.2.1"
-# aws-smithy-runtime = { version = "1.7.4", features = ["client", "connector-hyper-0-14-x", "test-util", "wire-mock"] }
+# aws-smithy-runtime = { version = "1.7.5", features = ["client", "connector-hyper-0-14-x", "test-util", "wire-mock"] }
 aws-sdk-s3 = { path = "../../motorcade/aws-sdk/sdk/s3", features = ["behavior-version-latest", "test-util"] }
 aws-smithy-checksums = { path = "../../motorcade/aws-sdk/sdk/aws-smithy-checksums" }
 aws-smithy-mocks-experimental = { path = "../../motorcade/aws-sdk/sdk/aws-smithy-mocks-experimental" }

diff --git a/aws-s3-transfer-manager/src/operation/upload.rs b/aws-s3-transfer-manager/src/operation/upload.rs
@@ -166,6 +166,8 @@ async fn put_object(
     }
 
     let resp = req
+        .customize()
+        .disable_payload_signing()
         .send()
         .instrument(tracing::info_span!(
             "send-upload-part",

diff --git a/aws-s3-transfer-manager/src/operation/upload/service.rs b/aws-s3-transfer-manager/src/operation/upload/service.rs
@@ -30,7 +30,6 @@ async fn upload_part_handler(request: UploadPartRequest) -> Result<CompletedPart
     let part_data = request.part_data;
     let part_number = part_data.part_number as i32;
 
-    // TODO(aws-sdk-rust#1159): disable payload signing
     let mut req = ctx
         .client()
         .upload_part()
@@ -54,6 +53,8 @@ async fn upload_part_handler(request: UploadPartRequest) -> Result<CompletedPart
     }
 
     let resp = req
+        .customize()
+        .disable_payload_signing()
         .send()
         .instrument(tracing::debug_span!("send-upload-part", part_number))
         .await?;