Add configurable visibility timeout default when using partial batch failures #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made this only applicable when |
normj
approved these changes
Aug 2, 2024
| /// </summary> | ||
| private async Task ResetVisibilityTimeoutForFailures() | ||
| { | ||
| if (_configuration.SQSEvent == null) return; |
There was a problem hiding this comment.
nit: Style wise can you either use brackets or put the return on a separate indented line?
philasmar
approved these changes
Aug 2, 2024
|
@brendonparker I have ran the integration tests and they have passed for this PR. Once you address Norm's comments, I can squash your commits and release the changes. |
|
@philasmar done |
|
This change was released in AWS.Messaging.Lambda (0.10.0). Thank you for your contribution @brendonparker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #150
Description of changes:
Adds a configuration option to LambdaMessagingOptions for a
VisibilityTimeoutvalue when there are partial batch failures. In that scenario, the failed messages will have their message visibility set to this default value.Prior to this change, the message visibility would not be set/changed. Which, if you were using a FIFO queue, would mean that other messages in that message group would be blocked until the original message visibility timeout occurred, which could be a while.
After this change, the message visibility will be changed on failure.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.