Update docker file for Oracle to import oracle-server.crt #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macohen
requested changes
Nov 19, 2024
| COPY target/athena-oracle-2022.47.1.jar ${LAMBDA_TASK_ROOT} | ||
| # Unpack the jar | ||
| RUN jar xf athena-oracle-2022.47.1.jar | ||
| ENV JAVA_TOOL_OPTIONS="-Djavax.net.ssl.trustStore=/usr/lib/jvm/java-11-openjdk/lib/security/cacerts -Djavax.net.ssl.trustStorePassword=changeit" |
There was a problem hiding this comment.
shouldn't the truststorepassword be a variable that can be passed in?
| @@ -1,9 +1,19 @@ | |||
| FROM public.ecr.aws/lambda/java:11 | |||
|
|
|||
| # Copy function code and runtime dependencies from Maven layout | |||
| ENV JAVA_HOME=/usr/lib/jvm/java-11-openjdk | |||
There was a problem hiding this comment.
should the JAVA_HOME be a variable to support additional JVMs?
| @@ -0,0 +1,24 @@ | |||
| -----BEGIN CERTIFICATE----- | |||
There was a problem hiding this comment.
We should not merge this PR with a cert like this. The user should provide the cert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Oracle ssl issue : javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
Description of changes:
Copied Java default cacerts to image location.
Installed oracle-server.crt in default truststore as it uses default truststore.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.