-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: support win/arm64 target #782
Conversation
Signed-off-by: maxcleme <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @maxcleme, thanks for the contribution. It will be nice to have this for Windows ARM.
Hey! Thanks for merging my PR! 🙇 Do you have idea when I can expect a proper Github release? 😁 Thanks again for such reactivity! |
@austinvazquez @pendo324 up? Sorry to bother again! Any timeline for a proper Github release for win/arm64 now? 😁 |
Apologies on my side. I am pushing to get this included in the v0.8.0 release. I wouldn't have a proper timeline just yet. Working to put together what is needed for that release. Let me take the action to create a milestone so you can at least follow that. Specifically for the Windows ARM release, I was working to add integration test support into the release pipeline; however, the rabbit hole I found myself in was Windows ARM containers seems to be bleeding edge. Microsoft doesn't seem to be shipping any ARM base containers. So we may need to mark the credential helper as experimental in documentation, but I don't see any reason why we cannot push it for trailblazers. :) |
@maxcleme, I have pushed through the items needed for 0.8.0 milestone (which I just realized I never actually shared; see https://github.com/awslabs/amazon-ecr-credential-helper/milestone/5) and opened #798 with the version and changelog updates required. I will try to put updates in the PR based on the progress of the release. |
Issue #, if available:
Description of changes:
Add support for win/arm64 target
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.