feat: add sagemaker-custom-kernel module
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
|
Tested E2E, including image updates (& enabled ECR image tag mutability). |
dgraeber
reviewed
Apr 6, 2024
|
Thanks @dgraeber yes it's moved from ADDF/IDF, IDF PR: awslabs/idf-modules#106, ADDF: https://github.com/awslabs/autonomous-driving-data-framework/tree/main/modules/sagemaker/custom-kernel |
Signed-off-by: Anton Kukushkin <[email protected]>
dgraeber
approved these changes
Apr 8, 2024
| - !Sub "arn:aws:iam::${AWS::AccountId}:role/${ProjectName}-${DeploymentName}-${ModuleName}-image-role" | ||
| - !Ref StudioExecutionRoleArn | ||
| - Action: | ||
| - "ecr:*LayerUpload" |
There was a problem hiding this comment.
Curious to know why do you need ECR IAM permissions? I have noticed you are building images using CDK Lib
There was a problem hiding this comment.
Good catch, yes, we no longer need it as it's handled by CDK now. Will fix in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
sagemaker-custom-kernelmoduleChecklist before requesting a review
CHANGELOG.MDwith a description of my changesscripts/validate.sh)seedfarmer applyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.