Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

correcting update behavior descriptions #904

Merged
merged 1 commit into from
Jan 13, 2021
Merged

correcting update behavior descriptions #904

merged 1 commit into from
Jan 13, 2021

Conversation

PatMyron
Copy link
Contributor

AWS::CloudTrail::Trail.TrailName requires: Replacement

inaccurate to translate "UpdateType": "Conditional" from the Resource Specification to say it retains the physical ID as detailed here

replacementStrategy can differ from the default

@PatMyron PatMyron requested a review from rachfop January 13, 2021 02:16
Copy link
Contributor

@rachfop rachfop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CloudTrail.Trail is interesting.

  1. Can we substitute an example in which the sentence "For example, if you update any property on the [Resource Name] resource, AWS CloudFormation updates the [resource] without disruption"?
  2. "a version property might be upgradable in-place but not downgradable in-place" - acknowledged
  3. replacementStrategy - acknowledged

@rachfop rachfop merged commit 89d2c9f into main Jan 13, 2021
@PatMyron PatMyron deleted the update-behaviors branch January 13, 2021 17:54
@PatMyron
Copy link
Contributor Author

  1. Can we substitute an example in which the sentence "For example, if you update any property on the [Resource Name] resource, AWS CloudFormation updates the [resource] without disruption"?

Definitely other resource types where that statement would still be true, but any new property type in the future could invalidate that statement (imagine that's what happened with AWS::CloudTrail::Trail.TrailName), so I figured the wording I put would be more future-proof

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants