observability naming adjustments #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madrigal
reviewed
Sep 18, 2024
|
|
||
| var aerr smithy.APIError | ||
| if $errors.As:T(err, &aerr) { | ||
| span.SetProperty("error.api.code", aerr.ErrorCode()) | ||
| span.SetProperty("error.api.message", aerr.ErrorMessage()) | ||
| span.SetProperty("error.api.fault", aerr.ErrorFault().String()) |
There was a problem hiding this comment.
What's fault in the context of Smithy?
There was a problem hiding this comment.
"client", "server" or "unknown"
There was a problem hiding this comment.
oh, like "who's fault is this".
I may be biased towards the errors I happen to be looking at right now, but this does seem useful for communicating with customers and saying "this is a client error, not an issue with the server", although I'd defer to your experience if you think this is not important
There was a problem hiding this comment.
Honestly, I'm fine leaving it
wty-Bryant
approved these changes
Sep 18, 2024
Madrigal
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smithyoteltracingandsmithyotelmetrics. Conventionally, when a module is also meant to be used as a package, it should have a valid package name.api.error_faultattribute since I don't think it really added any value