Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to checkstyle 10.17.0 #526

Merged
merged 1 commit into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions codegen/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ subprojects {

tasks["checkstyleTest"].enabled = false

checkstyle {
toolVersion = "10.17.0"
}

/*
* Tests
* ====================================================
Expand Down
2 changes: 1 addition & 1 deletion codegen/config/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
<!-- Checks for Javadoc comments. -->
<!-- See http://checkstyle.sf.net/config_javadoc.html -->
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="accessModifiers" value="public"/>
<property name="allowMissingParamTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
<property name="allowedAnnotations" value="Override, Test"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ private String formatWithNamespace(Symbol symbol) {
* Implements Go symbol formatting for the {@code $P} formatter. This is identical to the $T
* formatter, except that it will add a * to symbols that can be pointers.
*/
private class PointableGoSymbolFormatter extends GoSymbolFormatter {
private final class PointableGoSymbolFormatter extends GoSymbolFormatter {
@Override
public String apply(Object type, String indent) {
String formatted = super.apply(type, indent);
Expand All @@ -957,7 +957,7 @@ private boolean isPointer(Object type) {
}
}

class GoWritableInjector extends GoSymbolFormatter {
private final class GoWritableInjector extends GoSymbolFormatter {
@Override
public String apply(Object type, String indent) {
if (!(type instanceof Writable)) {
Expand All @@ -975,7 +975,7 @@ public String apply(Object type, String indent) {
/**
* Implements Go symbol formatting for the {@code $D} formatter.
*/
private class GoDependencyFormatter implements BiFunction<Object, String, String> {
private final class GoDependencyFormatter implements BiFunction<Object, String, String> {
@Override
public String apply(Object type, String indent) {
if (type instanceof GoDependency) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ default void generateAuth(GenerationContext context) {
/**
* Context object used for service serialization and deserialization.
*/
class GenerationContext {
final class GenerationContext {
private final GoSettings settings;
private final Model model;
private final ServiceShape service;
Expand Down
Loading