Setup Go Server codegen #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
setup-server-plugin
branch
from
7d82b5a to
94fe8a4
Compare
mtdowling
reviewed
Jan 29, 2024
| @@ -49,6 +50,10 @@ default byte getOrder() { | |||
| return 0; | |||
| } | |||
|
|
|||
| default ArtifactType getArtifactType() { | |||
There was a problem hiding this comment.
Is it possible for a plugin to work for either artifact type? What's this used for?
| @@ -70,7 +71,8 @@ | |||
| * <p>Reserved words for Go are automatically escaped so that they are | |||
| * suffixed with "_". See "reserved-words.txt" for the list of words. | |||
| */ | |||
| final class SymbolVisitor implements SymbolProvider, ShapeVisitor<Symbol> { | |||
There was a problem hiding this comment.
nit - is this really a SymbolVisitor or a ShapeVisitor?
| @@ -79,8 +80,10 @@ final class CodegenVisitor extends ShapeVisitor.Default<Void> { | |||
| LOGGER.info("Attempting to discover GoIntegration from the classpath..."); | |||
| ServiceLoader.load(GoIntegration.class, loader) | |||
| .forEach(integration -> { | |||
| LOGGER.info(() -> "Adding GoIntegration: " + integration.getClass().getName()); | |||
| integrations.add(integration); | |||
| if (integration.getArtifactType().equals(ArtifactType.CLIENT)) { | |||
There was a problem hiding this comment.
Is there any kind of future refactoring that removes the need to add these kinds of conditionals inside of codegen?
|
|
||
| @Override | ||
| public void execute(PluginContext context) { | ||
| String onlyBuild = System.getenv("SMITHY_GO_BUILD_API"); |
There was a problem hiding this comment.
What is going on here? Feels like this needs a comment at least.
lucix-aws
reviewed
Jan 29, 2024
| protocolDocumentGenerator = new ProtocolDocumentGenerator(settings, model, writers); | ||
|
|
||
| // TODO(SSDK): do we need this? | ||
| this.eventStreamGenerator = new EventStreamGenerator(settings, model, writers, symbolProvider, service); |
There was a problem hiding this comment.
FWIW we probably won't get to event streams in our current scope
lucix-aws
reviewed
Jan 29, 2024
|
|
||
| public interface ProtocolGenerator { | ||
| @SmithyInternalApi | ||
| public interface ServerProtocolGenerator { |
There was a problem hiding this comment.
Was there a reason we moved this?
syall
force-pushed
the
setup-server-plugin
branch
from
383eb2e to
8819a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch
feat-svcgenshould NOT be merged into main; everything in the branch is a POC.Issue #, if available:
N/A.
Description of changes:
Setup Go Server codegen
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.