Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Smithy 1.39 #452

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Upgrade to Smithy 1.39 #452

merged 5 commits into from
Sep 27, 2023

Conversation

isaiahvita
Copy link
Contributor

Pull in endpoints2.0 refactor

@isaiahvita isaiahvita requested review from a team as code owners September 26, 2023 15:10
syall
syall approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@syall syall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nit would be using the iterator directly.

@syall syall mentioned this pull request Sep 26, 2023
Closed
@isaiahvita isaiahvita merged commit c962dc4 into aws:main Sep 27, 2023
40 checks passed
@isaiahvita isaiahvita deleted the feat-endpoints-refactor branch September 27, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucix-aws lucix-aws lucix-aws approved these changes

@syall syall syall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaiahvita @syall @lucix-aws