Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recovery mode home path #546

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ChaonengQuan
Copy link
Contributor

@ChaonengQuan ChaonengQuan commented Jan 13, 2025

  • Fix the home directory env variable
  • add supervisord as the dependency for recovery-mode micromamba env

aws-tianquaw
aws-tianquaw previously approved these changes Jan 13, 2025
aws-tianquaw
aws-tianquaw previously approved these changes Jan 13, 2025
@ChaonengQuan
Copy link
Contributor Author

ChaonengQuan commented Jan 14, 2025

image size is still 7.99GB, because superviord is super light weight, only 14MB

localhost/sagemaker-distribution                                 2.3.0-cpu               3ea5f0ffc357   About an hour ago   7.99GB

claytonparnell
claytonparnell previously approved these changes Jan 14, 2025
@ChaonengQuan
Copy link
Contributor Author

unit tests passed

(sagemaker-distribution) [ec2-user@ip-172-31-33-40 sagemaker-distribution-condarc-fix]$ pytest -n auto -rA --local-image-version 2.3.0 -m cpu -k 'sagemaker-recovery-mode.test'
============================================================ test session starts ============================================================
platform linux -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /home/ec2-user/sagemaker-distribution-condarc-fix
configfile: pytest.ini
plugins: xdist-3.6.1, mock-3.14.0
64 workers [1 item]       
.                                                                                                                                     [100%]
============================================================= warnings summary ==============================================================
../micromamba/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426: 64 warnings
  /home/ec2-user/micromamba/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    EPOCH_NAIVE = datetime.utcfromtimestamp(0)

src/utils.py:4: 64 warnings
  /home/ec2-user/sagemaker-distribution-condarc-fix/src/utils.py:4: DeprecationWarning: conda.cli.python_api is deprecated and will be removed in 25.9. Use `conda.testing.conda_cli` instead.
    import conda.cli.python_api

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================== PASSES ===================================================================
___________________________ test_dockerfiles_for_cpu[sagemaker-recovery-mode.test.Dockerfile-required_packages31] ___________________________
[gw0] linux -- Python 3.12.8 /home/ec2-user/micromamba/envs/sagemaker-distribution/bin/python3.12
----------------------------------------------------------- Captured stdout call ------------------------------------------------------------
Will start running test for: sagemaker-recovery-mode.test.Dockerfile against: localhost/sagemaker-distribution:2.3.0-cpu
Built a test image: sha256:84ca01dae90dd4bb0b05863bcb4a2ef58ab1b340f4dbd19df3e5f5efe46e207a, will now execute its default CMD.
Starting test to verify JupyterLab can be started...
Container logs indicate JupyterLab started successfully.
Stopped and removed the container.
========================================================== short test summary info ==========================================================
PASSED test/test_dockerfile_based_harness.py::test_dockerfiles_for_cpu[sagemaker-recovery-mode.test.Dockerfile-required_packages31]
====================================================== 1 passed, 128 warnings in 7.32s ======================================================
(sagemaker-distribution) [ec2-user@ip-172-31-33-40 sagemaker-distribution-condarc-fix]$ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants