Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed Pandas tests #478

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix failed Pandas tests #478

merged 1 commit into from
Sep 25, 2024

Conversation

aws-tianquaw
Copy link
Contributor

Issue #, if available: #110

Description of changes: Fix failed Pandas tests

Latest failures in 2.x images:

FAILED pandas/tests/indexes/object/test_indexing.py::TestSliceLocs::test_slice_locs_negative_step[in_slice13--string[pyarrow_numpy]]
FAILED pandas/tests/plotting/frame/test_frame.py::TestDataFramePlots::test_plot_scatter_shape
FAILED pandas/tests/plotting/test_datetimelike.py::TestTSPlot::test_mpl_nopandas
ERROR pandas/tests/io/test_clipboard.py::TestClipboard::test_round_trip_frame_sep[delims-None-None]
ERROR pandas/tests/io/test_clipboard.py::TestClipboard::test_round_trip_frame_sep[delims-None-\t]
ERROR pandas/tests/io/test_clipboard.py::TestClipboard::test_round_trip_frame_sep[delims-None-,]
ERROR pandas/tests/io/test_clipboard.py::TestClipboard::test_round_trip_frame_sep[delims-None-|]
...
= 3 failed, 200972 passed, 21585 skipped, 7049 deselected, 1971 xfailed, 88 xpassed, 26 warnings, 327 errors

The 3 test failures can be fixed by upgrading from pandas-2.2.2 to pandas-2.2.3. The 327 errors are due to missing of dependency pyqt. Given that this package is not a marquee package in SDM images, we should disable such tests that require this dependency.

After the above changes, all tests passed:

200970 passed, 21732 skipped, 1971 xfailed, 88 xpassed, 26 warnings in 376.44s (0:06:16)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-tianquaw aws-tianquaw merged commit ffb42e0 into aws:main Sep 25, 2024
1 check passed
@balajisankar15
Copy link
Contributor

Note: You can still install pyqt as part of the test dockerfile and run those tests. Our goal is to ensure that all features of Pandas are working correctly (even if it has optional dependencies)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants