fix: add tensorflow and pytorch CUDA version tests for GPU image build #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRNWWZ
changed the title
TRNWWZ
changed the title
balajisankar15
previously approved these changes
Jul 9, 2024
JunLyu
reviewed
Jul 9, 2024
| # Raise exception if CUDA is not detected | ||
| if 'cuda' not in package_build: | ||
| raise Exception("Pytorch is installed without CUDA support for GPU image build.") | ||
|
|
There was a problem hiding this comment.
Maybe also do a print here "Pytorch is built with CUDA support"
There was a problem hiding this comment.
Maybe also do a print here "Pytorch is built with CUDA support"
Good point, updated exception message
JunLyu
reviewed
Jul 9, 2024
| ARG SAGEMAKER_DISTRIBUTION_IMAGE | ||
| FROM $SAGEMAKER_DISTRIBUTION_IMAGE | ||
|
|
||
| ARG MAMBA_DOCKERFILE_ACTIVATE=1 |
There was a problem hiding this comment.
afaik, these 3 lines are used to activate test environment, we have it in other tests too: https://github.com/aws/sagemaker-distribution/blob/main/test/test_artifacts/v1/autogluon.test.Dockerfile#L1-L4
JunLyu
previously approved these changes
Jul 9, 2024
balajisankar15
previously approved these changes
Jul 9, 2024
claytonparnell
approved these changes
Jul 9, 2024
balajisankar15
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
In 1.8.0 GPU image, we installed tensorflow-cpu version by mistake
Description of changes:
To get rid of such issue, add a unit test to validate tensorflow and pytorch cuda version is installed in GPU image
Test:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.