Skip to content

Commit

Permalink
feature: Add dependencies for amazon-sagemaker-sql extension
Browse files Browse the repository at this point in the history
  • Loading branch information
kumarnzt authored and dylanraws committed Mar 7, 2024
1 parent 4fd13e2 commit b610971
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
conda-forge::jupyter_server_fileid
conda-forge::jupyter_ydoc
conda-forge::jupyter_ydoc
conda-forge::amazon_sagemaker_sql_editor[version='>=0.1.0,<2']
conda-forge::amazon-sagemaker-sql-magic[version='>=0.1.0,<2']
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
conda-forge::jupyter_server_fileid
conda-forge::jupyter_ydoc
conda-forge::jupyter_ydoc
conda-forge::amazon_sagemaker_sql_editor[version='>=0.1.0,<2']
conda-forge::amazon-sagemaker-sql-magic[version='>=0.1.0,<2']
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
ARG COSMOS_IMAGE
FROM $COSMOS_IMAGE

ARG MAMBA_DOCKERFILE_ACTIVATE=1

CMD ["python", "-c", "import amazon_sagemaker_sql_magic"]
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
ARG COSMOS_IMAGE
FROM $COSMOS_IMAGE

ARG MAMBA_DOCKERFILE_ACTIVATE=1

CMD ["python", "-c", "import amazon_sagemaker_sql_editor"]
8 changes: 6 additions & 2 deletions test/test_dockerfile_based_harness.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@
("jupyterlab-git.test.Dockerfile", ['jupyterlab-git']),
("serve.test.Dockerfile", ['serve-langchain']),
("jupyter-server-fileid.test.Dockerfile", ['jupyter_server_fileid']),
("jupyter-ydoc.test.Dockerfile", ['jupyter_ydoc'])])
("jupyter-ydoc.test.Dockerfile", ['jupyter_ydoc'])],
("amazon-sagemaker-sql-magic.test.Dockerfile", ['amazon-sagemaker-sql-magic']),
("amazon_sagemaker_sql_editor.test.Dockerfile", ['amazon_sagemaker_sql_editor']))
def test_dockerfiles_for_cpu(dockerfile_path: str, required_packages: List[str],
local_image_version: str, use_gpu: bool):
_validate_docker_images(dockerfile_path, required_packages, local_image_version, use_gpu, 'cpu')
Expand Down Expand Up @@ -72,7 +74,9 @@ def test_dockerfiles_for_cpu(dockerfile_path: str, required_packages: List[str],
("jupyterlab-git.test.Dockerfile", ['jupyterlab-git']),
("serve.test.Dockerfile", ['serve-langchain']),
("jupyter-server-fileid.test.Dockerfile", ['jupyter_server_fileid']),
("jupyter-ydoc.test.Dockerfile", ['jupyter_ydoc'])])
("jupyter-ydoc.test.Dockerfile", ['jupyter_ydoc'])],
("amazon-sagemaker-sql-magic.test.Dockerfile", ['amazon-sagemaker-sql-magic']),
("amazon_sagemaker_sql_editor.test.Dockerfile", ['amazon_sagemaker_sql_editor']))
def test_dockerfiles_for_gpu(dockerfile_path: str, required_packages: List[str],
local_image_version: str, use_gpu: bool):
_validate_docker_images(dockerfile_path, required_packages, local_image_version, use_gpu, 'gpu')
Expand Down

0 comments on commit b610971

Please sign in to comment.