Add retry on errors for update command #91
+413
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Introduces a new flag (
--retry-errors) to configureupdateto retry indefinitely when a error happens. The retry code uses back-off and jitter, with different back-off formulas depending on the type of error.This flag is mutually exclusive with
--once. The default behavior is still the "fail fast" mode: the creds file is continuously updated before the creds expire but the program exists if an error is encountered.This new retry mode is useful when running
updateas a background unattended process, for example as a systemd service. The user could could handle retries in the service itself, however that mechanism wouldn't be aware of the type of error and it might make difficult to make the retries intelligent taking into account things like the type of errors.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.