Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For etcd metrics, specify explictily proxy steps are only for stacked etcd #9131

Merged

Conversation

rajeshvenkata
Copy link
Member

Issue #, if available:

Description of changes:
Update the metrics doc for etcd metrics to specify explictily that proxy steps are only for stacked setup

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2025
Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.35%. Comparing base (60225bb) to head (32e2a84).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9131   +/-   ##
=======================================
  Coverage   72.35%   72.35%           
=======================================
  Files         585      585           
  Lines       45686    45686           
=======================================
  Hits        33058    33058           
  Misses      10890    10890           
  Partials     1738     1738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisnegus
Copy link
Member

/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 64184e1 into aws:main Jan 7, 2025
8 checks passed
@rajeshvenkata rajeshvenkata deleted the expose-metrics-specify-stacked branch January 7, 2025 17:54
@rajeshvenkata
Copy link
Member Author

/cherry-pick release-0.21

@rajeshvenkata
Copy link
Member Author

/cherry-pick release-0.20

@rajeshvenkata
Copy link
Member Author

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@rajeshvenkata: new pull request created: #9168

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@rajeshvenkata: new pull request created: #9169

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@rajeshvenkata: new pull request created: #9170

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants