-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For etcd metrics, specify explictily proxy steps are only for stacked etcd #9131
For etcd metrics, specify explictily proxy steps are only for stacked etcd #9131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small suggestion.
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Negus <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9131 +/- ##
=======================================
Coverage 72.35% 72.35%
=======================================
Files 585 585
Lines 45686 45686
=======================================
Hits 33058 33058
Misses 10890 10890
Partials 1738 1738 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.21 |
/cherry-pick release-0.20 |
/cherry-pick release-0.19 |
@rajeshvenkata: new pull request created: #9168 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rajeshvenkata: new pull request created: #9169 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rajeshvenkata: new pull request created: #9170 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes:
Update the metrics doc for etcd metrics to specify explictily that proxy steps are only for stacked setup
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.