Add bootOptions to cp/md tinkerbellmachine template, fix unit-tests #9094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/M
rahulbabu95
force-pushed
the
tink/fix-flags-crds
branch
from
8e04adc to
7ed6c7c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9094 +/- ##
==========================================
- Coverage 72.41% 72.41% -0.01%
==========================================
Files 578 578
Lines 45590 45589 -1
==========================================
- Hits 33016 33015 -1
Misses 10838 10838
Partials 1736 1736 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rahul Ganesh <[email protected]>
rahulbabu95
force-pushed
the
tink/fix-flags-crds
branch
from
7ed6c7c to
448760f
Compare
jacobweinstock
approved these changes
Dec 20, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Latest release of CAPT, supports
bootOptionsin theTinkerbellMachineSpec. In EKS-A this translates totinkerbellMachineTemplatehaving those fields configurable for Control-Plane and MachineDeployment. DefaultbootModetonetbootin this change. I will follow up with the conditional logic to toggle between netboot and isoboot in a different PR that'll introduce L3 provisioning changes to EKS-A.Also, update Smee flags as all smee flags start with
SMEE_prefix and the previousBOOTS_KUBE_NAMESPACEwas invalid. RemovePUBLIC_SYSLOG_IPas it is not a valid flag in the latest version.Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.