-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vmotion Guidelines to EKS-A docs #8852
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8852 +/- ##
==========================================
- Coverage 73.77% 72.39% -1.38%
==========================================
Files 578 578
Lines 36832 45373 +8541
==========================================
+ Hits 27173 32850 +5677
- Misses 7929 10792 +2863
- Partials 1730 1731 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Abhay Krishna <[email protected]>
Co-authored-by: Abhay Krishna <[email protected]>
Co-authored-by: Abhay Krishna <[email protected]>
Co-authored-by: Abhay Krishna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work. Most of my comments are formatting and style issues. I like the new Nodes section. As you suggested, I think it will be a good place to put more content for managing EKS Anywhere nodes.
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more EKS-A and indent corrections.
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.21 |
@sp1999: new pull request created: #8899 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.20 |
@sp1999: new pull request created: #8900 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.19 |
@sp1999: new pull request created: #8901 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
2572
Description of changes:
Added section to vsphere troubleshooting to give guidance on using VMware vmotion with EKS-A clusters.
Testing (if applicable):
Documentation added/planned (if applicable):
Adding section to vsphere troubleshooting.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.