Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vmotion Guidelines to EKS-A docs #8852

Merged
merged 53 commits into from
Oct 23, 2024
Merged

Add Vmotion Guidelines to EKS-A docs #8852

merged 53 commits into from
Oct 23, 2024

Conversation

mimcdevitt
Copy link
Member

@mimcdevitt mimcdevitt commented Oct 16, 2024

Issue #, if available:
2572

Description of changes:
Added section to vsphere troubleshooting to give guidance on using VMware vmotion with EKS-A clusters.

Testing (if applicable):

Documentation added/planned (if applicable):
Adding section to vsphere troubleshooting.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.39%. Comparing base (7415c2b) to head (80d1357).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8852      +/-   ##
==========================================
- Coverage   73.77%   72.39%   -1.38%     
==========================================
  Files         578      578              
  Lines       36832    45373    +8541     
==========================================
+ Hits        27173    32850    +5677     
- Misses       7929    10792    +2863     
- Partials     1730     1731       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2024
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2024
Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work. Most of my comments are formatting and style issues. I like the new Nodes section. As you suggested, I think it will be a good place to put more content for managing EKS Anywhere nodes.

docs/content/en/docs/clustermgmt/nodes/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more EKS-A and indent corrections.

docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/nodes/vmotion.md Outdated Show resolved Hide resolved
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit f634117 into aws:main Oct 23, 2024
8 checks passed
@sp1999
Copy link
Member

sp1999 commented Oct 24, 2024

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8899

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Oct 24, 2024

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8900

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Oct 24, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8901

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants