doc: update Cilium validation #8492
Conversation
|
Hi @viktor-kurchenko. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eks-distro-bot
added
needs-ok-to-test
size/M
|
@csplinter could you please review? |
viktor-kurchenko
force-pushed
the
pr/vk/cilium/doc/update
branch
from
d4d603e to
33ebf3e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8492 +/- ##
==========================================
- Coverage 72.35% 72.35% -0.01%
==========================================
Files 585 585
Lines 45686 45686
==========================================
- Hits 33058 33055 -3
- Misses 10890 10892 +2
- Partials 1738 1739 +1 ☔ View full report in Codecov by Sentry. |
|
Instead of replacing the current validation steps, we can probably add the Cilium CLI as an alternative way to validate. |
I afraid we can't. The manifest https://docs.isovalent.com/v1.10/public/connectivity-check-eksa.yaml already deprecated and functionality moved in the Cilium CLI. |
|
hi 👋 - @mitalipaygude any updates on this? This is the only current supported way of validating the cluster connectivity. Thank you. |
There was a problem hiding this comment.
LGTM, thanks!
Given that the current instructions suggest to deploy a deprecated YAML that pulls an image with dozens of CVEs, I think that this is in the best interests of eks-anywhere users to leverage actively supported tooling for validating whether the environment is healthy or not.
|
@joestringer: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@viktor-kurchenko is this still good to merge or are there any more changes to this PR? If you're still interested in merging this, could you rebase with current changes on main? Thank you! |
* Update docs/content/en/docs/tasks/workload/networking-and-security.md to use Cilium CLI instead of connectivity check YAML manifest. Signed-off-by: viktor-kurchenko <[email protected]>
viktor-kurchenko
force-pushed
the
pr/vk/cilium/doc/update
branch
from
33ebf3e to
96c9a62
Compare
Yes, I think it's still relevant. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-0.21 |
|
/cherrypick release-0.20 |
|
/cherrypick release-0.19 |
|
@abhay-krishna: new pull request created: #9165 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhay-krishna: new pull request created: #9166 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhay-krishna: new pull request created: #9167 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
docs/content/en/docs/tasks/workload/networking-and-security.mdto use Cilium CLI instead of connectivity check YAML manifest.