Group all dependabot go changes in one PR a week #8427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having one PR per module can be annoying. On top of that, a lot of the times, changes in main have effects in the release module (since we do an import with a replace from disk). The drawback of this change is that when code changes are required for a particular module, the go.mod change will be mixed with other modules, thus requiring us to separate the problematic node from the rest before merging. From the experience running this bot during the past few months, there is usually no work to do except to approve, no code required most of the time. Hence this will reduce the amount of PRs we need to review and the amount of time we need to manually update them to simply run go mod tidy.
eks-distro-bot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8427 +/- ##
=======================================
Coverage 73.48% 73.48%
=======================================
Files 578 578
Lines 36489 36489
=======================================
Hits 26814 26814
Misses 7956 7956
Partials 1719 1719 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Having one PR per module can be annoying. On top of that, a lot of the times, changes in main have effects in the release module (since we do an import with a replace from disk).
The drawback of this change is that when code changes are required for a particular module, the go.mod change will be mixed with other modules, thus requiring us to separate the problematic node from the rest before merging. From the experience running this bot during the past few months, there is usually no work to do except to approve, no code required most of the time. Hence this will reduce the amount of PRs we need to review and the amount of time we need to manually update them to simply run go mod tidy.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.