Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a nil pointer error #8403

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix a nil pointer error #8403

merged 1 commit into from
Jun 27, 2024

Conversation

d8660091
Copy link
Member

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@d8660091
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d8660091

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.48%. Comparing base (07d37a2) to head (442ae51).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8403   +/-   ##
=======================================
  Coverage   73.48%   73.48%           
=======================================
  Files         578      578           
  Lines       36489    36489           
=======================================
  Hits        26814    26814           
  Misses       7956     7956           
  Partials     1719     1719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d8660091
Copy link
Member Author

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@d8660091: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rahulbabu95
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit 5a794dd into aws:main Jun 27, 2024
12 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@d8660091: new pull request created: #8405

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Jul 19, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: #8403 failed to apply on top of branch "release-0.19":

Applying: Fix a nil pointer error
Using index info to reconstruct a base tree...
M	internal/pkg/ssm/run_output.go
Falling back to patching base and 3-way merge...
Auto-merging internal/pkg/ssm/run_output.go
CONFLICT (content): Merge conflict in internal/pkg/ssm/run_output.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix a nil pointer error
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants