Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws sdk modules to latest version #7415

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

g-gaston
Copy link
Member

Description of changes:
This should resolve an issue with incompatible aws sdk modules. This is due to a recent update we did where we bumped some of them but not all. Normally this should be fine, however, a change in the aws sdk made old modules incompatible with new modules.

More info: aws/aws-sdk-go-v2#2370 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This should resolve an issue with incompatible aws sdk modules. This is
due to a recent update we did where we bumped some of them but not all.
Normally this should be fine, however, a change in the aws sdk made old
modules incompatible with new modules.

More info: aws/aws-sdk-go-v2#2370 (comment)
@g-gaston g-gaston requested a review from taneyland January 29, 2024 23:30
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e72b325) 72.01% compared to head (e3a91c7) 72.03%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7415      +/-   ##
==========================================
+ Coverage   72.01%   72.03%   +0.01%     
==========================================
  Files         566      567       +1     
  Lines       44185    44220      +35     
==========================================
+ Hits        31821    31854      +33     
- Misses      10618    10620       +2     
  Partials     1746     1746              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g-gaston
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 643ab56 into aws:main Jan 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants