fix(amazonq): zip entry contains invalid characters #5274
+31
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Code reviews sometimes fail due to invalid zip entry path error for certain workspace configurations.
Root cause:
The condition
selectedFile.path.startsWith(projectRoot.path)
string comparison incorrectly returns true if the selected file is not in the projectRoot but has a partial path prefix match of the projectRoot.For example:
Solution:
Use built-in VirtualFile util method to check if the file is actually within the projectRoot.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.