telemetry(amazonq): invalid zip event #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishrp-aws
approved these changes
Jan 15, 2025
manodnyab
reviewed
Jan 15, 2025
| @@ -177,6 +177,21 @@ | |||
| "reloaded" | |||
| ], | |||
| "description": "Toolkit run state." | |||
| }, | |||
There was a problem hiding this comment.
can this be added to common?
There was a problem hiding this comment.
I can follow up with a separate PR after this
rli
reviewed
Jan 15, 2025
...ws/toolkits/jetbrains/services/codewhisperer/codescan/sessionconfig/CodeScanSessionConfig.kt
Outdated
Show resolved
Hide resolved
rli
approved these changes
Jan 15, 2025
| @@ -195,6 +196,9 @@ class CodeScanSessionConfig( | |||
| files.forEach { file -> | |||
| try { | |||
| val relativePath = "${project.name}/${file.relativeTo(projectRoot.toNioPath())}" | |||
| if (relativePath.contains("../") || relativePath.contains("..\\")) { | |||
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
* telemetry(amazonq): invalid zip event * check windows path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Service is receiving invalid zip files which are created with invalid entry path. This change adds a telemetry metric to capture more data when this happens.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.