Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Secrets Manager Db2 JDBC driver #219

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

willtong1234
Copy link
Contributor

Issue #, if available:

Description of changes:

Adding Secrets Manager Db2 JDBC driver

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (5e7e921) 74.05% compared to head (279fc84) 72.47%.

Files Patch % Lines
...secretsmanager/sql/AWSSecretsManagerDb2Driver.java 50.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
- Coverage     74.05%   72.47%   -1.58%     
- Complexity      117      124       +7     
============================================
  Files            11       12       +1     
  Lines           343      367      +24     
  Branches         42       44       +2     
============================================
+ Hits            254      266      +12     
- Misses           82       94      +12     
  Partials          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willtong1234 willtong1234 merged commit 6073977 into master Dec 6, 2023
4 checks passed
@willtong1234 willtong1234 deleted the develop-master branch December 6, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants