Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker with cgroup2 detection #116

Merged
merged 4 commits into from
Apr 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Unreleased Changes
------------------
* Issue - Fix `EbsSqsActiveJobMiddleware` to detect Docker container with cgroup2. (#116).

3.11.0 (2024-03-01)
------------------
Expand Down
10 changes: 9 additions & 1 deletion lib/aws/rails/middleware/ebs_sqs_active_job_middleware.rb
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,15 @@ def sent_from_docker_host?(request)
end

def app_runs_in_docker_container?
@app_runs_in_docker_container ||= `[ -f /proc/1/cgroup ] && cat /proc/1/cgroup` =~ /docker/
@app_runs_in_docker_container ||= in_docker_container_with_cgroup1? || in_docker_container_with_cgroup2?
end

def in_docker_container_with_cgroup1?
File.exist?('/proc/1/cgroup') && File.read('/proc/1/cgroup') =~ %r{/docker/}
end

def in_docker_container_with_cgroup2?
File.exist?('/proc/self/mountinfo') && File.read('/proc/self/mountinfo') =~ %r{/docker/containers/}
end

def default_gw_ips
Expand Down
58 changes: 58 additions & 0 deletions test/aws/rails/middleware/ebs_sqs_active_job_middleware_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,64 @@ module Rails
expect(response[2]).to eq(['Successfully ran job ElasticBeanstalkJob.'])
end

it 'successfully invokes job in docker container with cgroup1' do
mock_rack_env = create_mock_env('172.17.0.1', 'aws-sqsd/1.1', false)
test_middleware = EbsSqsActiveJobMiddleware.new(mock_rack_app)

proc_1_cgroup = <<~CONTENT
13:rdma:/docker/d59538e9b3d3aa6012f08587c13199cbad3f882ecaa9637905971df18ab89757
12:hugetlb:/docker/d59538e9b3d3aa6012f08587c13199cbad3f882ecaa9637905971df18ab89757
11:memory:/docker/d59538e9b3d3aa6012f08587c13199cbad3f882ecaa9637905971df18ab89757
10:devices:/docker/d59538e9b3d3aa6012f08587c13199cbad3f882ecaa9637905971df18ab89757
9:blkio:/docker/d59538e9b3d3aa6012f08587c13199cbad3f882ecaa9637905971df18ab89757
CONTENT

allow(File).to receive(:exist?).and_call_original
allow(File).to receive(:read).and_call_original

expect(File).to receive(:exist?).with('/proc/1/cgroup').and_return(true)
expect(File).to receive(:read).with('/proc/1/cgroup').and_return(proc_1_cgroup)

response = test_middleware.call(mock_rack_env)

expect(response[0]).to eq(200)
expect(response[1]['Content-Type']).to eq('text/plain')
expect(response[2]).to eq(['Successfully ran job ElasticBeanstalkJob.'])
end

it 'successfully invokes job in docker container with cgroup2' do
mock_rack_env = create_mock_env('172.17.0.1', 'aws-sqsd/1.1', false)
test_middleware = EbsSqsActiveJobMiddleware.new(mock_rack_app)

proc_1_cgroup = <<~CONTENT
0::/
CONTENT

proc_self_mountinfo = <<~CONTENT
355 354 0:21 / /sys/fs/cgroup ro,nosuid,nodev,noexec,relatime - cgroup2 cgroup rw,nsdelegate
356 352 0:74 / /dev/mqueue rw,nosuid,nodev,noexec,relatime - mqueue mqueue rw
357 352 0:79 / /dev/shm rw,nosuid,nodev,noexec,relatime - tmpfs shm rw,size=65536k
358 350 8:16 /var/lib/docker/containers/69e3febd00ac4720d2ea58c935574776285f6a0016d2aa30b0c280a81c385e69/resolv.conf /etc/resolv.conf rw,relatime - ext4 /dev/sdb rw,discard,errors=remount-ro,data=ordered
359 350 8:16 /var/lib/docker/containers/69e3febd00ac4720d2ea58c935574776285f6a0016d2aa30b0c280a81c385e69/hostname /etc/hostname rw,relatime - ext4 /dev/sdb rw,discard,errors=remount-ro,data=ordered
360 350 8:16 /var/lib/docker/containers/69e3febd00ac4720d2ea58c935574776285f6a0016d2aa30b0c280a81c385e69/hosts /etc/hosts rw,relatime - ext4 /dev/sdb rw,discard,errors=remount-ro,data=ordered
316 352 0:77 /0 /dev/console rw,nosuid,noexec,relatime - devpts devpts rw,gid=5,mode=620,ptmxmode=666
CONTENT

allow(File).to receive(:exist?).and_call_original
allow(File).to receive(:read).and_call_original

expect(File).to receive(:exist?).with('/proc/1/cgroup').and_return(true)
expect(File).to receive(:read).with('/proc/1/cgroup').and_return(proc_1_cgroup)
expect(File).to receive(:exist?).with('/proc/self/mountinfo').and_return(true)
expect(File).to receive(:read).with('/proc/self/mountinfo').and_return(proc_self_mountinfo)

response = test_middleware.call(mock_rack_env)

expect(response[0]).to eq(200)
expect(response[1]['Content-Type']).to eq('text/plain')
expect(response[2]).to eq(['Successfully ran job ElasticBeanstalkJob.'])
end

# Create a minimal mock Rack environment hash to test just what we need
def create_mock_env(source_ip, user_agent, is_periodic_task = false)
mock_env = {
Expand Down
Loading