PR feedback and fixes

lib/aws/rails/middleware/elastic_beanstalk_sqsd.rb

@@ -64,7 +64,7 @@ def _execute_periodic_task(job_name)
           job.perform_now
         rescue NameError => e
           @logger.error("Periodic task #{job_name} could not resolve to an Active Job class " \
-                        '- check the spelling in cron.yaml.')
+                        '- check the cron name spelling and set the path as / in cron.yaml.')
           @logger.error("Error: #{e}.")
           raise e
         end

lib/aws/rails/railtie.rb

@@ -51,7 +51,7 @@ class Railtie < ::Rails::Railtie
       end
 
       # Register a middleware that will handle requests from the Elastic Beanstalk worker SQS Daemon.
-      initializer 'aws-sdk-rails.add-sqsd-middleware', after: :build_middleware_stack do |app|
+      initializer 'aws-sdk-rails.add-sqsd-middleware', before: :build_middleware_stack do |app|
         Aws::Rails.add_sqsd_middleware(app)
       end
     end

sample-app/Gemfile

@@ -1,10 +1,8 @@
 source "https://rubygems.org"
 
 # Our gems
-gem 'aws-sdk-rails',
-    # path: '../'
-    git: 'https://github.com/aws/aws-sdk-rails', branch: '4.2'
-
+# bundle config set local.aws-sdk-rails ../
+gem 'aws-sdk-rails', git: 'https://github.com/aws/aws-sdk-rails', branch: '5.0'
 gem 'aws-actiondispatch-dynamodb' #, git: 'https://github.com/aws/aws-actiondispatch-dynamodb-ruby'
 gem 'aws-actionmailbox-ses' #, git: 'https://github.com/aws/aws-actionmailbox-ses-ruby'
 gem 'aws-actionmailer-ses' #, git: 'https://github.com/aws/aws-actionmailer-ses-ruby'

sample-app/README.md

@@ -112,9 +112,7 @@ Inspect the output of `Aws.config` and ensure the credentials are set.
 
 ### Setup
 
-This is configured in `config/initializers/instrument_aws_sdk.rb`. See the `aws-sdk-rails` README.
-
-`UsersController#index` captures any AWS SDK notification with:
+This is configured in `config/initializers/notifications.rb`. See the `aws-sdk-rails` README.
 
 ```ruby
 ActiveSupport::Notifications.subscribe(/[.]aws/) do |name, start, finish, id, _payload|

sample-app/app/controllers/users_controller.rb

@@ -3,9 +3,6 @@ class UsersController < ApplicationController
 
   # GET /users
   def index
-    ActiveSupport::Notifications.subscribe(/[.]aws/) do |name, start, finish, id, _payload|
-      Rails.logger.info "Got notification: #{name} #{start} #{finish} #{id}"
-    end
     @users = User.all
   end
 

sample-app/config/initializers/notifications.rb

@@ -0,0 +1,3 @@
+ActiveSupport::Notifications.subscribe(/[.]aws/) do |name, start, finish, id, _payload|
+  Rails.logger.info "Got notification: #{name} #{start} #{finish} #{id}\n"
+end