Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add spec typecheck to integration step #6666

Merged
merged 2 commits into from
Nov 14, 2024
Merged

test: add spec typecheck to integration step #6666

merged 2 commits into from
Nov 14, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 14, 2024

Adds a phony make target called test-types, which runs during integration tests.

It typechecks all test code (*.spec.ts), since vitest does not do so by default, and we previously did this with jest.

P.S. vitest is supposed to natively support this with typecheck.includes, but I couldn't get that to work.

@kuhe kuhe requested a review from a team as a code owner November 14, 2024 21:05
@kuhe kuhe merged commit a0be64f into aws:main Nov 14, 2024
2 checks passed
Copy link

github-actions bot commented Dec 1, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants