Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws-sdk-core module import #6505

Closed
wants to merge 2 commits into from
+5 −1
Closed

Fix aws-sdk-core module import #6505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b4848c
Import the whole core module
rohangupta6807 Sep 23, 2024
995badc
exported legacy module
rohangupta6807 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/client-dynamodb/src/DynamoDBClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// smithy-typescript generated code
import { AccountIdEndpointMode } from "@aws-sdk/core/account-id-endpoint";
import { AccountIdEndpointMode } from "@aws-sdk/core";
Copy link
Contributor

@kuhe kuhe Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want to do this because it merges the submodule into the package root. We will use the fix described in #6502 (comment)

import {
EndpointDiscoveryInputConfig,
EndpointDiscoveryResolvedConfig,
Expand Down
4 changes: 4 additions & 0 deletions packages/core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ export * from "./submodules/httpAuthSchemes/index";
* Legacy submodule.
*/
export * from "./submodules/protocols/index";
/**
* Legacy submodule.
*/
export * from "./submodules/account-id-endpoint/index";

/**
* Warning: do not export any additional submodules from the root of this package. See readme.md for
Expand Down