Migrate util-endpoints package #5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
force-pushed
the
migrate-util-endpoints
branch
from
05e90d2 to
e39e7e1
Compare
kuhe
approved these changes
Oct 20, 2023
syall
reviewed
Oct 24, 2023
srchase
force-pushed
the
migrate-util-endpoints
branch
2 times, most recently
from
28b96ca to
13b44de
Compare
syall
approved these changes
Oct 24, 2023
srchase
force-pushed
the
migrate-util-endpoints
branch
from
13b44de to
a19eeaa
Compare
kuhe
approved these changes
Oct 26, 2023
srchase
force-pushed
the
migrate-util-endpoints
branch
from
a19eeaa to
86a8d1d
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corresponds to the changes in smithy-lang/smithy-typescript#1044 and smithy-lang/smithy-typescript#1043.
Part of the @aws-sdk/util-endpoints package is migrated to the newly added @smithy/util-endpoints package.
@aws-sdk/util-endpoints retrains AWS specific endpoint resolution functions, which are injected into clients for use by @smithy/util-endpoints for resolving endpoints.
Testing
Tests are now split between @smithy/util-endpoints and @aws-sdk/util-endpoints.
Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.