-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(signature-v4-crt): remove dynamic imports (!) #5225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Sep 15, 2023
kuhe
changed the title
fix(util-user-agent-node): use import.meta and require.resolve
fix(util-user-agent-node): use import() and require.resolve
Sep 15, 2023
kuhe
changed the title
fix(util-user-agent-node): use import() and require.resolve
fix(signature-v4-crt): remove dynamic imports (!)
Sep 18, 2023
kuhe
force-pushed
the
chore/crt
branch
3 times, most recently
from
September 18, 2023 17:04
96356b7
to
1f27302
Compare
3 tasks
|
trivikr
approved these changes
Oct 25, 2023
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5221
closes #5216
closes #5135
related to #2822 (pin)
removes dynamic imports and checks for aws-crt.
This requires users to install and import
@aws-sdk/signature-v4-crt
explicitly where before they would only have to install it, and is a slightly breaking change, but would greatly improve the experience around bundlers or strict ESM crashing on the dynamic import.Currently:
npm i @aws-sdk/signature-v4-crt # to be found by dynamic import
Proposed in PR:
npm i @aws-sdk/signature-v4-crt # will not be found dynamically