feat(region-config-provider): Add region-config-provider package #5156
Conversation
AndrewFossAWS
force-pushed
the
region-config
branch
from
12fb746 to
ce7fd35
Compare
AndrewFossAWS
changed the title
| * Resolved value for input {@link RegionInputConfig.useFipsEndpoint} | ||
| */ | ||
| useFipsEndpoint: Provider<boolean>; | ||
| } |
There was a problem hiding this comment.
the input and resolved config are duplicates to types in smithy/config-resolver, what's the plan for these, co-existence or deprecation of one?
Can you just import the types from there?
There was a problem hiding this comment.
No because the concept of region is AWS specific and should belong to aws-js-sdk-v3. "region" related files in @smithy/config-resolver should be deprecated.
| /** | ||
| * @internal | ||
| */ | ||
| export const getRealRegion = (region: string) => |
There was a problem hiding this comment.
Out of curiosity, where did the name for this function come from?
I'm wondering if there is a more descriptive name for this.
There was a problem hiding this comment.
A lot of files from this PR are copied directly from @smithy/config-resolver. The names should be kept the same for now.
AndrewFossAWS
force-pushed
the
region-config
branch
from
ce7fd35 to
eedf48f
Compare
AndrewFossAWS
force-pushed
the
region-config
branch
from
eedf48f to
229c3b2
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Description
config-resolverpackage to aws-sdk-js-v3'sregion-config-providerpackageTesting
Additional context
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.