-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java.lang.IllegalStateException: The service request was not made within 10 seconds of doBlockingWrite being invoked. Make sure to invoke the service request BEFORE invoking doBlockingWrite if your caller is single-threaded.ription)(short issue description) #4893
Comments
Hi @ramakrishna-g1 apologies for the silence. We identified an issue with multipart uploads using BlockingInputStream where the client enters a bad state and doesn't recover from it. We are working on a fix. We'll also consider creating a timeout configuration so this default value can be customized. Will keep this updated with progress of the fix. |
Would this apply when using I am running into a similar issue Also any eta on a fix? Thx |
Running into this issue with BlockingInputStreamAsyncRequestBody instead of the Output body. Default S3Async setup and creds.
|
Hey all, we've exposed an option to allow users to configure
|
In which version fix is available? |
2.25.8 |
This issue describes the timeout problem in the BlockingInputStreamAsyncRequestBody, but the change made by #5000 adds the configuration option to BlockingOutputStreamAsyncRequestBody. Is a similar configuration option going to be exposed for the BlockingInputStreamAsyncRequestBody as well? |
Hi @nredhefferprovidertrust #4893 is created to add the same config for BlockingInputStreamAsyncRequestBody |
What is the best fail-safe value for .subscribeTimeout() in the PROD environment. where we have uploading thousands of messages per minute. |
Hi @zoewangg, I see that you have provided an option to extend the timeout which is good. But it still doesn't solve the original issue of the client going into an unhealthy state. So is there going to be a fix for that? |
Yes, we have a task in our backlog to fix the issue. No ETA to share at the moment. |
Hello! Are any updates on this issue, or any recommendation on how to avoid this? I am using CRT Client along with I notice it happens when S3 starts responding backoff and throttling responses. The client enters an unrecoverable bad state and everything after that throws the timeout error described by OP. For now, I replaced the implementation with AsyncRequestBody.fromInputStream(inputStream, fileSize, executorService) This however requires a separate executor service which makes not much sense for us, as we will just block the calling thread uploading the file anyways. We are using private void copyFile(URL source, String destination, long fileSize) {
try (InputStream inputStream = urlStreamReader.read(source)) {
BlockingInputStreamAsyncRequestBody requestBody =
AsyncRequestBody.forBlockingInputStream(fileSize);
Upload upload = transferManager.upload(
UploadRequest.builder()
.putObjectRequest(PutObjectRequest.builder()
.bucket(s3BucketName)
.expectedBucketOwner(s3BucketOwner)
.key(destination)
.build())
.requestBody(requestBody)
.build());
// Blocks calling thread
requestBody.writeInputStream(inputStream);
upload.completionFuture().join();
}
} |
Hi @debora-ito are there any updates for the fix for BlockingInputStreamAsyncRequestBody? |
Was able to bypass the issue using this approach (Scala). val body: BlockingInputStreamAsyncRequestBody = BlockingInputStreamAsyncRequestBody.builder().subscribeTimeout(Duration.ofSeconds(30)).build()
val upload: Upload = transferManager.upload(UploadRequest.builder().requestBody(body).putObjectRequest(request).build())
body.writeInputStream(inputStream) |
I also get this exception seemingly "randomly" with code that looks like this (CRT client as this , as I understand it is required to do streaming with unknown size):
and would really like to find a work-around as this is to fragile to use in production... For me specifying the size in advance is not an option (that this in unknown is the whole point for me of using streaming as the data is generated over some time andf total data size may be far larger than I could hold in memory). |
I use your method, it still has this problem |
Is it still going on |
Unless my code pasted above has some error it seems to me there is still some intermittent problem with the SDK implementation of S3 streaming.... |
Seems like when s3 api exception like 403 happends, async client is not trying to consume (subscribe) BlockingInputStreamAsyncRequestBody. |
Describe the bug
The service request was not made within 10 seconds of doBlockingWrite being invoked. Make sure to invoke the service request BEFORE invoking doBlockingWrite if your caller is single-threaded.
at software.amazon.awssdk.core.async.BlockingInputStreamAsyncRequestBody.waitForSubscriptionIfNeeded(BlockingInputStreamAsyncRequestBody.java:110) ~[sdk-core-2.22.2.jar!/:na]
at software.amazon.awssdk.core.async.BlockingInputStreamAsyncRequestBody.writeInputStream(BlockingInputStreamAsyncRequestBody.java:74) ~[sdk-core-2.22.2.jar!/:na]
Expected Behavior
We are experiencing these failures very often even after using latest aws crt client "aws-crt-client" 2.23.12.
We expect this to wait for longer time / should have option to increase the time out which would be helpful when there is huge data with large files.
Current Behavior
We are trying to steam large number of files from source system to AWS s3 using Transfer manager by reading the stream using HttpURLConnection, below is sample code -
URL targetURL = new URL("URL");
HttpURLConnection urlConnection = (HttpURLConnection) targetURL.openConnection();
urlConnection.setRequestMethod(HttpMethod.GET.toString());
urlConnection.setRequestProperty(HttpHeaders.ACCEPT, MediaType.ALL_VALUE);
if (urlConnection.getResponseCode() == HttpStatus.OK.value()) {
BlockingInputStreamAsyncRequestBody body = AsyncRequestBody.forBlockingInputStream(null);
Upload upload = transferManager.upload(builder -> builder
.requestBody(body)
.addTransferListener(UploadProcessListener.create(fileTracker.getPath()))
.putObjectRequest(req -> req.bucket(s3BucketName).key("v3/" + s3Key + "/" + fileTracker.getPath()))
.build());
}
Reproduction Steps
URL targetURL = new URL("URL");
HttpURLConnection urlConnection = (HttpURLConnection) targetURL.openConnection();
urlConnection.setRequestMethod(HttpMethod.GET.toString());
urlConnection.setRequestProperty(HttpHeaders.ACCEPT, MediaType.ALL_VALUE);
if (urlConnection.getResponseCode() == HttpStatus.OK.value()) {
BlockingInputStreamAsyncRequestBody body = AsyncRequestBody.forBlockingInputStream(null);
Upload upload = transferManager.upload(builder -> builder
.requestBody(body)
.addTransferListener(UploadProcessListener.create(fileTracker.getPath()))
.putObjectRequest(req -> req.bucket(s3BucketName).key("v3/" + s3Key + "/" + fileTracker.getPath()))
.build());
}
Possible Solution
No response
Additional Information/Context
Last week I have created ticket(awslabs/aws-crt-java#754) under aws-crt-java, as per the suggestion/comments creating this ticket here.
AWS Java SDK version used
2.23.12
JDK version used
11
Operating System and version
window / linux
The text was updated successfully, but these errors were encountered: