Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to configure subscribeTimeout for BlockingOutputStreamAsyncRequestBody. #5000

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Mar 7, 2024

Motivation and Context

BlockingOutputStreamAsyncRequestBody currently will timeout if the async request body is not subscribed after 10 seconds.

S3 CRT client will queue requests once it runs out of connections and if users send a lot of requests, it's likely those requests will not get executed within 10 seconds.

This PR allows users to configure subscribeTimeout for BlockingOutputStreamAsyncRequestBody. Related to #4893

Modifications

Expose subscribeTimeout config for BlockingOutputStreamAsyncRequestBody

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner March 7, 2024 04:18
@anirudh9391
Copy link
Contributor

I know this was in response to a specific customer reported error in the multi-upload scenario. Is there a way for us to verify that it is solved ?

@zoewangg
Copy link
Contributor Author

zoewangg commented Mar 8, 2024

Is there a way for us to verify that it is solved ?

This allows user to extend timeout. I did some testing and it should work now. We'll need to check if the SDK is propagating cancellation correctly.

@zoewangg zoewangg enabled auto-merge (squash) March 8, 2024 23:19
@zoewangg zoewangg disabled auto-merge March 12, 2024 03:29
@zoewangg zoewangg enabled auto-merge (squash) March 12, 2024 03:30
Copy link

sonarcloud bot commented Mar 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants