Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misaligned struct member used in atomic operation #5182

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix misaligned struct member used in atomic operation #5182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d0da27
Fix misaligned struct member used in atomic operation
dswarbrick Feb 27, 2024
a49c26d
add changelog
lucix-aws May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG_PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
### SDK Enhancements

### SDK Bugs
* Fix misaligned struct member used in atomic operation.
* This change fixes panics on 32-bit systems in services that use endpoint discovery.
6 changes: 3 additions & 3 deletions aws/crr/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ import (
// based on some key. The datastructure makes use of a read write
// mutex to enable asynchronous use.
type EndpointCache struct {
endpoints syncMap
endpointLimit int64
// size is used to count the number elements in the cache.
// The atomic package is used to ensure this size is accurate when
// using multiple goroutines.
size int64
size int64
endpoints syncMap
endpointLimit int64
}

// NewEndpointCache will return a newly initialized cache with a limit
Expand Down
Loading