env config consistent naming and replaced usage of deprecated ioutil #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
reviewed
Dec 4, 2024
| @@ -29,9 +28,9 @@ const ( | |||
|
|
|||
| awsSessionTokenEnvVar = "AWS_SESSION_TOKEN" | |||
|
|
|||
| awsContainerCredentialsEndpointEnvVar = "AWS_CONTAINER_CREDENTIALS_FULL_URI" | |||
There was a problem hiding this comment.
If we're bikeshedding, then I'd prefer *Env - e.g. awsContainerCredentialsEndpointEnv
Signed-off-by: christophrj <[email protected]>
christophrj
force-pushed
the
fix/env-config-typo
branch
from
46da168 to
daa0aee
Compare
|
We recently added instructions on how to generate a changelog entry for PRs. In the past, we had to do this on behalf of contributors, slowing down the review process. Can you go through this document and generate a changelog entry for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds consistent naming of env config constants and drops the usage of (deprecated) ioutils