Feat s3 transfer manager v2 PutObject #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing. I know that some of the business logic is duplicated from the original version here, but I'm reviewing it as if it's all new. |
lucix-aws
requested changes
Aug 5, 2024
Madrigal
reviewed
Aug 5, 2024
Madrigal
reviewed
Aug 21, 2024
lucix-aws
requested changes
Aug 21, 2024
There was a problem hiding this comment.
We need to seriously re-examine the part pool behavior. It seems entirely overcomplicated for what we need out of it.
We need to discuss how we manage maximum part size of 10k for MPUs - failing on an in-progress download from exceeding the limit after the fact isn't acceptable behavior.
wty-Bryant
force-pushed
the
feat-tmv2-putobject
branch
2 times, most recently
from
f3a43fb to
ba7b247
Compare
wty-Bryant
force-pushed
the
feat-tmv2-putobject
branch
from
e4c3fe7 to
734b574
Compare
lucix-aws
reviewed
Nov 1, 2024
added 9 commits
November 4, 2024 17:17
merge main dev branch into current feature branch
lucix-aws
reviewed
Nov 6, 2024
| ExpectError string | ||
| } | ||
|
|
||
| func testPutObject(t *testing.T, bucket string, testData putObjectTestData, opts ...func(options *tm.Options)) { |
lucix-aws
approved these changes
Nov 6, 2024
Madrigal
reviewed
Nov 6, 2024
Madrigal
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement v2 s3 transfer manager's putobject api bound to single union client which mimics normal service client's initialization and api call.
Test: passed unit test for putobject and pool, passed integration test of uploading object via transfer manager v2 and validating its content after downloading through s3 client