Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: normalize adding of sigv4a config based on trait presence #2465

Merged
merged 1 commit into from
Jan 24, 2024
Merged

codegen: normalize adding of sigv4a config based on trait presence #2465

merged 1 commit into from
Jan 24, 2024

Conversation

lucix-aws
Copy link
Contributor

Normalize auth codegen for sigv4a:

  • internal signer config and resolution is now driven by presence of SigV4ATrait
  • sha256 payload middleware will now generate when either of the v4 traits are present

All services were regenerated with this change and in terms of codegen this is largely a no-op. Explanation of diffs:

  • Removed redundant code leftover from SRA refactor:
    • defaulting of DisableURIPathEscaping, this is now controlled by signer properties
    • resolveCredentialProvider in each sigv4a service, the Options' GetIdentityResolver API now handles this (the asymmetric wrapper)
    • swapWithCustomHTTPSignerMiddleware - obsolete by new SRA auth resolution
    • The check for a credentials provider in s3 presigning w/ v4a is redundant w/ SRA refactor (scheme would never be selected in the first place)
  • Incidental rearrangement of some codegen due to switching integrations (no change in behavior)
    • various sigv4a internals in eventbridge
    • resolveHTTPSignerV4a

@lucix-aws lucix-aws requested a review from a team as a code owner January 23, 2024 23:27
@lucix-aws lucix-aws self-assigned this Jan 23, 2024
wty-Bryant
wty-Bryant approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@wty-Bryant wty-Bryant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a changelog for the PR?

isaiahvita
isaiahvita approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@isaiahvita isaiahvita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this. this does make it more standard and cleaner rather than having the s3, eventbridge, and cfkvs all implement similar logic

@lucix-aws lucix-aws merged commit 7365edd into main Jan 24, 2024
12 checks passed
@lucix-aws lucix-aws deleted the codegen-sigv4aconfig branch January 24, 2024 18:35
@brandur brandur mentioned this pull request Jan 29, 2024
Closed
mmoghaddam385 added a commit to polygon-io/aws-sdk-go-v2 that referenced this pull request Feb 1, 2024
@mmoghaddam385 @lucix-aws
@wty-Bryant @isaiahvita @RanVaknin @milesziemer @kellertk
Merge upstream (#3)
fe14af3 
* feat: sra identity&auth refactor (aws#2364)

* Update API model

* Update endpoints model

* Update SDK's smithy-go dependency to v1.17.0

* Regenerated Clients

* Release 2023-11-15

* fix trailing comment parse in properties (aws#2371)

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-11-16

* Remove macie service

* Add changelog for last commit

* Merge customizations for service s3

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-11-17

* deprecate v4.SignHTTPRequestMiddleware (aws#2375)

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-11-20

* fix: don't send 0 max items for object version and multipart upload paginators (aws#2380)

* fix: don't expect response to be json in endpointcreds provider (aws#2381)

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-11-21

* breakfix: convert public access block config fields to nilable like s3 (aws#2385)

* Update API model

* Regenerated Clients

* Release 2023-11-22

* rebase to main branch

* Add changelog

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-11-27

* Update API model

* Regenerated Clients

* Release 2023-11-27.2

* fix: respect functional option modifications to RetryMaxAttempts (aws#2390)

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-11-28

* Change request compression codegen to operation level

* Merge customizations for service s3

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-11-28.2

* fix: correct wiring of disable s3express auth toggle (aws#2394)

* Change requestion compression comment

* Release 2023-11-28.3

* Update golang.org/x/net dependency (aws#2391)

* feat: add Options() getter to service clients (aws#2398)

* Update API model

* Update SDK's smithy-go dependency to v1.18.0

* Regenerated Clients

* Release 2023-11-29

* regenerate sdk

* Update API model

* Update endpoints model

* Update SDK's smithy-go dependency to v1.18.1

* Regenerated Clients

* Release 2023-11-30

* fix: use region overrides in endpoint discovery (aws#2393)

* Update API model

* Regenerated Clients

* Release 2023-11-30.2

* fix: correct wrapping of errors in authentication workflow (aws#2403)

* fix: correct recognition and zeroing of cache-wrapped AnonymousCredentials (aws#2404)

* Update API model

* Regenerated Clients

* Release 2023-12-01

* feat: add express integration test (aws#2402)

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-04

* Add request compression assertion to protocol unit tests

* Smithy upgrade (aws#2407)

* Update API model

* Regenerated Clients

* Release 2023-12-05

* Restore pre-SRA optionalAuth/no-auth behaviors (aws#2410)

* Update API model

* Regenerated Clients

* Release 2023-12-06

* Change config loading logic

* regenerate partitions (aws#2415)

* fix codegen ci (aws#2418)

* Update API model

* Update endpoints model

* Update SDK's smithy-go dependency to v1.19.0

* Regenerated Clients

* Release 2023-12-07

* fix: add non-vhostable buckets to path when using legacy endpoint resolver (aws#2417)

* update express cache key (aws#2414)

* fix: translation of ini service sections into shared config (aws#2416)

* fix: reinstate presence of retryer when functional opts run but still respect max attempts set therein (aws#2420)

* Update API model

* Regenerated Clients

* Release 2023-12-08

* Update API model

* Regenerated Clients

* Release 2023-12-11

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-12

* fix missing smithy-go checkout on main

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-13

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-14

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-15

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-18

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-19

* Update API model

* Update endpoints model

* Update partitions file

* Regenerated Clients

* Release 2023-12-20

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-21

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-22

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-26

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-27

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2023-12-28

* Update API model

* Regenerated Clients

* Release 2023-12-29

* removed incorrect description

* changelog added

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2024-01-03

* Fix SRA auth trailing checksum retry bug (aws#2438)

* Update API model

* Regenerated Clients

* Release 2024-01-04

* codegen: track upstream sigv4a trait changes (aws#2442)

* Update API model

* Regenerated Clients

* Release 2024-01-05

* Update API model

* Regenerated Clients

* Release 2024-01-08

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2024-01-10

* Add smoke test traits dep

Adds a dependency on smithy-smoke-test-traits in the sdk code gen
package so aws service models that use the smokeTests trait won't
fail to build because of unknown traits. Generated a client with
a smoke test and confirmed there was no diff.

Adding the dependency in the code gen package since it's the models
that need the dependency, not the code generator. When smoke tests
are implemented in the generator, we can add the dep there.

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2024-01-11

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2024-01-12

* Update API model

* Regenerated Clients

* Release 2024-01-14

* Fix signing bug in CFKVS service (aws#2452)

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2024-01-16

* Update API model

* Regenerated Clients

* Release 2024-01-17

* Remove invalid defaults from a few services (aws#2458)

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2024-01-18

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2024-01-19

* fix: remove invalid escaping of shared config values (aws#2461)

* Update API model

* Regenerated Clients

* Release 2024-01-22

* Update API model

* Regenerated Clients

* Release 2024-01-23

* codegen: normalize adding of sigv4a config based on trait presence (aws#2465)

* Update API model

* Regenerated Clients

* Release 2024-01-24

* Update API model

* Regenerated Clients

* Release 2024-01-25

* Minor GitHub workflow changes (aws#2466)

* chore: a more polite closed issue message

* chore: relax stale issue timing

* Update API model

* Regenerated Clients

* Release 2024-01-26

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2024-01-29

* Update API model

* Regenerated Clients

* Release 2024-01-30

* Update API model

* Update endpoints model

* Regenerated Clients

* Release 2024-01-31

---------

Co-authored-by: Luc Talatinian <[email protected]>
Co-authored-by: AWS SDK for Go v2 automation user <[email protected]>
Co-authored-by: Tianyi Wang <[email protected]>
Co-authored-by: Eren Yeager <[email protected]>
Co-authored-by: Isaiah Vita <[email protected]>
Co-authored-by: Luc Talatinian <[email protected]>
Co-authored-by: Ran Vaknin <[email protected]>
Co-authored-by: Ran Vaknin <[email protected]>
Co-authored-by: Miles Ziemer <[email protected]>
Co-authored-by: Miles Ziemer <[email protected]>
Co-authored-by: Tom Keller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wty-Bryant wty-Bryant wty-Bryant approved these changes

@isaiahvita isaiahvita isaiahvita approved these changes

Assignees

@lucix-aws lucix-aws

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucix-aws @isaiahvita @wty-Bryant