Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Skip use_containerized test temporarily #151

Merged
merged 3 commits into from
Nov 22, 2024
Merged

chore: Skip use_containerized test temporarily #151

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f16da1b
chore: Skip use_containerized test temporarily
hnnasit Nov 22, 2024
b3647d6
chore: only skip x86 tests
hnnasit Nov 22, 2024
64c5a3b
add missing quotation mark
hnnasit Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/build_image_base_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,11 @@ def test_external_apps(self):
self.assertTrue(out.decode().find("Build Succeeded"))

def test_containerized_build(self):
if self.runtime in SKIP_CONTAINERIZED_BUILD_TESTS:
self.skipTest(f"Skipping for {self.runtime}")
# Skip this test for now as these checks are failing for x86
# TODO: Add the checks back once the below docker issue is fixed
# Error: 500 Server Error for : Internal Server Error ("failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: unable to apply cgroup configuration: cannot enter cgroupv2 "/sys/fs/cgroup/docker" with domain controllers -- it is in threaded mode: unknown")
if self.runtime in SKIP_CONTAINERIZED_BUILD_TESTS or self.tag == "x86_64":
self.skipTest(f"Skipping for {self.runtime} and architecture: {self.tag}")
init_args = [
"sam",
"init",
Expand Down