Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address issues with release of react 19 #898

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

cogwirrel
Copy link
Member

React 19 removes the global JSX namespace - replace with React.JSX which works with both React 19 and 18. Additionally address type error with new versions of react-router-dom's navigate function returning a promise.

Fixes #895
Fixes #896

React 19 removes the global JSX namespace - replace with React.JSX which works with both React 19
and 18. Additionally address type error with new versions of react-router-dom's `navigate` function
returning a promise.

Fixes #895
Fixes #896
Copy link

nx-cloud bot commented Dec 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f917a67. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@cogwirrel cogwirrel merged commit 6c662d4 into mainline Dec 19, 2024
4 checks passed
@cogwirrel cogwirrel deleted the fix/react-19 branch December 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants