fix: use pnpm deploy to pack against to ensure all bundled dependenci… #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are included fix #755
van-vothanh
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundled dependencies were not being included correctly due to some janky linking code that didn't handle multiple versions of the same package.
With the release of
pnpm deploywe can simply now deploy a fresh copy of the package to a new directory by hoisting the dependencies and and pack from there which correctly creates an 'npm-like' nestednode_modules. As you can see below,[email protected]is nested underneath the@babel/highlightpackage whilst the[email protected]is available at the root ofnode_modules.Fixes #755