feat(type-safe-api): expose managed rule props to allow consumers to … #712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # NA
This PR introduce the ability to modify the Waf managed rule set provided by the consumers in order to allow customisations that include, for example, the ability to change the individual rule behaviour inside a ruleset.
A common example is related to the
AWSManagedRulesCommonRuleSet
which has a strict rule namedSizeRestrictions_BODY
that allow only 8Kb body payload. With the current implementation provided by PDK the only option we have is to either disable Waf altogether or add a different rule set to override the default behaviour. The interface provided by type safe api doesn't provide the ability to modify the ruleset rules.With this change, consumers can override individual rules in the ruleset as the entire CDK interface is shared to the consumer.
In order to have backwards compatibility this PR keep the usage of both
vendor
andvendorName
properties. In future PDK iterations it's suggested to removevendor
to keep onlyvendorName
using the default interface provided by CDK