feat: upgrade projen to 0.79 #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade projen to 0.79 Fixes #661
agdimech
approved these changes
Jan 31, 2024
cogwirrel
force-pushed
the
feat/projen-0.79
branch
from
d1bba60 to
d9d5dac
Compare
agdimech
reviewed
Jan 31, 2024
…ojects projen version This change ensures all subprojects of a monorepo have the same projen version as the monorepo itself for non-runtime dependencies, and sets the default projen version to 0.79.x. This also provides a single place to change when updating the peer dependency version of projen for PDK, which will automatically ensure vended PDK projects have that same version and we avoid the "unmet peer" warning in future. Fixes #661
cogwirrel
force-pushed
the
feat/projen-0.79
branch
from
d9d5dac to
028c53b
Compare
agdimech
reviewed
Feb 1, 2024
I'll send a followup PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade projen to ^0.79.6
It may also be worth "pinning" the projen version for the projects PDK exports to the same as the peer dep version to avoid this "unmet peer" issue going forward.This PR also sets a default version of projen at the monorepo level, and ensures the projen version is synchronised across all subprojects. This default version is the same as the PDK peer dependency version (since PDK dogfoods the TS monorepo), which ensures we won't hit the "unmet peer" issue when projen bump to 0.80 and beyond, and we can update projen in our own time.
Note that projen's test behaviour of synthing to a tmp dir when
NODE_ENV=testwas set has changed, so I needed to set a different environment variable to avoid breaking all our tests :)Fixes #661