Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate AWS SDK for JavaScript v2 APIs to v3 in static-website #632

Merged
merged 7 commits into from
Nov 5, 2023
Merged

chore: migrate AWS SDK for JavaScript v2 APIs to v3 in static-website #632

merged 7 commits into from
Nov 5, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 3, 2023

From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

@trivikr trivikr changed the title chore: run [email protected] on packages/static-website/**/*.ts chore: migrate AWS SDK for JavaScript v2 APIs to v3 in static-website Nov 3, 2023
@trivikr
Copy link
Member Author

trivikr commented Nov 3, 2023

Maintainers: I'm not sure why CI is failing.

Feel free to take over this PR when you review it.

@agdimech
Copy link
Contributor

agdimech commented Nov 5, 2023

Maintainers: I'm not sure why CI is failing.

Feel free to take over this PR when you review it.

It is because the SDK versions need to match across packages. I've just updated them for you :)

@agdimech agdimech marked this pull request as ready for review November 5, 2023 22:12
Copy link
Contributor

@agdimech agdimech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading this, greatly appreciated :)

@agdimech agdimech merged commit 73f8771 into aws:mainline Nov 5, 2023
3 checks passed
@trivikr trivikr deleted the aws-sdk-js-codemod branch November 6, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants