fix(infrastructure): fix java compilation issue without api, and skip unused constructs in java/py #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unused constructs in java/py The Java website construct didn't compile when an api wasn't present due to some extra brackets being commented out. Additionally the website construct would always be rendered for typescript even if no website was configured. Likewise for Java and Python, the api and website constructs were always rendered. This PR also adds tests for the infrastructure projects.
cogwirrel
force-pushed
the
fix/infrastructure-bugs
branch
from
7b22426 to
cbf0f6b
Compare
agdimech
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java website construct didn't compile when an api wasn't present due to some extra brackets being commented out, and a duplicate constructor with the same signature.
Additionally the website construct would always be rendered for typescript even if no website was configured. Likewise for Java and Python, the api and website constructs were always rendered.
This PR also adds tests for the infrastructure projects.