fix(type-safe-api): fix typescript handler dist path for operations with inline request bodies #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith inline request bodies When an operation has inline request body schemas (rather than a $ref) in OpenAPI, the operation ID is suffixed with "Operation" in the generated code, but the operation nickname remains unchanged. Previously, the operation ID was used for the handler dist reference in the generated functions, but the nickname was used to generate the actual filename. Address this by using the nickname in both places for typescript generated functions. Fixes #606
agdimech
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an operation has inline request body schemas (rather than a
$ref) in OpenAPI, the operation ID is suffixed withOperationin the generated code, but the operation "nickname" remains unchanged.eg. operationID =
sayHelloOperation, nickname =sayHelloPreviously, the operation ID was used for the handler dist reference in the generated lambda function constructs (eg referencing
say-hello-operationin thedistfolder), but the nickname was used to generate the actual filename (egsay-hello.ts, which becomessay-hello/index.jsin thedistfolder). This meant that the reference pointed to a folder that didn't exist!Address this by using the nickname in both places for typescript generated functions.
Fixes #606