fix(type-safe-api): fix generated react hooks compilation issues #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tanstack/react-query v5 was released earlier, and the hooks project did not pin the version resulting in code which failed to compile. Additionally the @paginated trait in Smithy specifies the Smithy member name which is not the name used in the final generated code, since Smithy -> OpenAPI translation will rename parameters to the name provided in the @HTTPHeader or @httpQuery traits. Additionally the generated typescript client will use valid parameter names, eg kebab-case becomes camelCase, so address this too. Fixes #604
martenpayne
approved these changes
Oct 18, 2023
|
looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tanstack/react-queryv5 was released earlier, and the hooks project did not pin the version resulting in code which failed to compile. Pin to v4 for now to address this.Additionally, the
@paginatedtrait in Smithy specifies the Smithy member name which is not the name used in the final generated code, since Smithy -> OpenAPI translation will rename parameters to the name provided in the@httpHeaderor@httpQuerytraits.Additionally the generated typescript client will use valid parameter names, eg kebab-case becomes camelCase, so we must address this too by ensuring we use camelCase in the generated hooks code.
Fixes #604