Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type-safe-api): add compilation to ESM for TypeScript #561

Merged
merged 8 commits into from
Sep 12, 2023
Merged

feat(type-safe-api): add compilation to ESM for TypeScript #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
33ebe6c
feat(type-safe-api): add compilation to ESM for TypeScript
zetashift Sep 4, 2023
04ee619
test(type-safe-api): add snapshots for ESM compilation
zetashift Sep 5, 2023
86b1cac
Merge branch 'mainline' into feat-add-esm-comp
cogwirrel Sep 6, 2023
5ad12c9
Merge branch 'mainline' into feat-add-esm-comp
agdimech Sep 6, 2023
a5e6403
Merge branch 'mainline' into feat-add-esm-comp
zetashift Sep 7, 2023
e191823
Merge branch 'mainline' into feat-add-esm-comp
cogwirrel Sep 8, 2023
f5f1ffe
Merge branch 'mainline' into feat-add-esm-comp
cogwirrel Sep 8, 2023
1b0d8b4
style(generated-typescript-runtime): fix formatting
zetashift Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/type-safe-api/src/project/codegen/runtime/generated-typescript-runtime-project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*! Copyright [Amazon.com](http://amazon.com/), Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: Apache-2.0 */
import { NodePackageUtils } from "@aws/monorepo";
import { IgnoreFile } from "projen";
import { IgnoreFile, JsonFile } from "projen";
import { NodePackageManager } from "projen/lib/javascript";
import { TypeScriptProject } from "projen/lib/typescript";
import { Language } from "../../languages";
Expand Down Expand Up @@ -121,6 +121,22 @@ export class GeneratedTypescriptRuntimeProject extends TypeScriptProject {

this.preCompileTask.spawn(generateTask);

// Add compilation to ESM as well
const compileESMTask = this.addTask("compile-esm");
compileESMTask.exec("tsc -p tsconfig.esm.json");
new JsonFile(this, "tsconfig.esm.json", {
obj: {
extends: "./tsconfig.dev.json",
compilerOptions: {
module: "esnext",
moduleResolution: "nodenext",
cogwirrel marked this conversation as resolved.
Show resolved Hide resolved
outDir: "lib/esm",
},
},
});

this.compileTask.spawn(compileESMTask);

// Ignore all the generated code
this.gitignore.addPatterns(
"src",
Expand Down
Loading
Loading