Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issues related to upgrading nx >= 16 #384

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

agdimech
Copy link
Contributor

@agdimech agdimech commented May 2, 2023

Resolve issues related to upgrading nx >= 16

  • Task execution order is now correct due to targetDefaults being set correctly
  • Updates to deprecated @nrwl packages
  • Pin nx as a peer dep to >= 16
  • Package versions are now resolved correctly due to recent change in Projen.
  • Removed uber package and refactored samples to take dependencies on individual packages

BREAKING CHANGE: Deprecate uber aws-prototyping-sdk package

Fixes #379, #381, #347

@nx-cloud
Copy link

nx-cloud bot commented May 2, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4a23a74. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link
Contributor

@JeremyJonas JeremyJonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you. Approved with comments, which if are as expected can merge.

nx.json Outdated Show resolved Hide resolved
nx.json Outdated Show resolved Hide resolved
packages/nx-monorepo/src/nx-monorepo.ts Outdated Show resolved Hide resolved
packages/nx-monorepo/src/nx-monorepo.ts Show resolved Hide resolved
resolve issues related to upgrading nx >= 16

BREAKING CHANGE: Deprecate uber aws-prototyping-sdk package

fix #379, #381, #347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error resolving versions of dependencies in a monorepo
2 participants