Skip to content

Commit

Permalink
fix(monorepo): add monorepo dep on @aws-cdk/aws-cognito-identitypool-…
Browse files Browse the repository at this point in the history
…alpha (#628)

Yarn doesn't automatically install peer dependencies, and so users would receive an error with a
missing package "@aws-cdk/aws-cognito-identitypool-alpha" when creating a new ts monorepo with yarn.
The other peer dependencies (eg cdk) were already included as deps, so we include this one so yarn
doesn't complain.

Fixes #580
  • Loading branch information
cogwirrel authored Nov 1, 2023
1 parent b78ac01 commit 586aa0b
Show file tree
Hide file tree
Showing 6 changed files with 187 additions and 47 deletions.
4 changes: 4 additions & 0 deletions .projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion packages/monorepo/src/projects/typescript/monorepo-ts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,13 @@ export class MonorepoTsProject
},
peerDeps: ["nx@^16", ...(options.peerDeps || [])],
devDeps: ["nx@^16", "@aws/pdk@^0", ...(options.devDeps || [])],
deps: ["aws-cdk-lib", "constructs", "cdk-nag", ...(options.deps || [])],
deps: [
"aws-cdk-lib",
"constructs",
"cdk-nag",
"@aws-cdk/aws-cognito-identitypool-alpha",
...(options.deps || []),
],
});

this.nxConfigurator = new NxConfigurator(this, {
Expand Down
Loading

0 comments on commit 586aa0b

Please sign in to comment.